[PATCH] Re: Minor planner bugs

[Martin Měřinský]

On St, 2015-10-21 at 09:59 +0200, Robert Helling wrote:
> Could you please check in the preferences if you have configured a
> default cylinder. If you do, what is it? Could you try if changing it
> to some other value from the list solves this problem?

I have no default cylinder preferences. Choosing any cylinder helps. I
wasn't aware of the existence of default cylinder :-)

Why there is empty value, in Default cylinder listbox? And why is it
default, if it causes such troubles?

> If there is no default cylinder, it should add an “unknown” cylinder of
> 11,1 liter size and 207 bar of air.

This doesn't work.

> Could you use a debugger to set a breakpoint at the start of that
> function and step through it to figure out how you can end up without a
> gas? If you don’t have access to a debugger or don’t know how to use
> it, I could send you a patch that adds printf’s in all kinds of places
> to determine the code path in your case, so let me know.

I can run debugger, but I don't know what to look for. Could it be
somewhere in endInsertRows() qt-models/diveplannermodel.cpp:658 ?

Breakpoint 1, DivePlannerPointsModel::addStop (this=0xb0ebc0,
milimeters=15000, seconds=1200, 
    gas_in=0x7fffffffd1d0, ccpoint=0, entered=true)
    at /home/mermar/ss/subsurface/qt-models/diveplannermodel.cpp:658
658		endInsertRows();
(gdb) s
this gas air should have been on the cylinder list
Things will fail now
this gas air should have been on the cylinder list
Things will fail now
659		return row;

After setting default cylinder, I don't get the warning. But still
cannot delete some gases, see
http://tmp.spvhd.cz/2015-10-21_subsurface_bug_2.ogv

Martin M.