[PATCH] Re: Minor planner bugs

[K. "pestophagous" Heller]

On Wed, Oct 21, 2015 at 12:59 AM, Robert Helling <helling at atdotde.de> wrote:
> Hi,
>
> I have to admit, I am totally lost here.
>
> Here is what I guess I figured out:
>
> First of all: The error message “Too many gas mixes” is totally misleading.

> In any case, the wording of the message needs to be changed.

That makes total sense.  Please do change the wording; it's a great idea.


> On Tue, Oct 20, 2015 at 1:04 AM, Robert Helling <helling at atdotde.de> wrote:
>
> you can end up with two waypoints of
> different depth at the same time but I could not make them do anything more
> strange. In particular I always ended up with a more or less reasonable dive

Interesting. If I end up with deltaT of two waypoints equal to zero
and then "Apply changes", that is a guaranteed way for me to see the
"Too many gas mixes".

I didn't think that Qt signal queueing varied too much between
platforms, but maybe (if you are on mac osx) you do not get the
"spurious" call to ProfileWidget2::plotDive. (I am on debian.)


> PROBLEM: dive_list()->unselectDives() triggers slots, and makes
> ProfileWidget2::plotDive get called, which calls create_dive_from_plan
> .... but "displayed_dive" is a totally zeroed-out dive. (it just got
> zeroed by clone_dive).
>
> I think this is a valid analysis. We had problems at other places when a
> replot was triggered while in the middle of some operation. For this there
> is
>
> MainWindow::instance()->graphics()->setReplot(false);
>

ahhh! good to know. That sounds like it would help me.  I will try it
and report back. Thanks!

/K