Fixing warning about freediving

Tomaz Canabrava tcanabrava at kde.org
Wed Oct 21 15:33:48 PDT 2015


I will have a bomb - patch for you guys in a few days. ;p
since I'll probably break a ton of builds, I guess I need to say this.

On Wed, Oct 21, 2015 at 8:26 PM, Guido Lerch <guido.lerch at gmail.com> wrote:

> heres another one for you to rewrite.
> let me know what and why you rewrote, otherwise I wont grow.
>
> 2015-10-22 0:16 GMT+02:00 Dirk Hohndel <dirk at hohndel.org>:
>
>> I was just about to look at that warning. Thanks for fixing it. I rewrote
>> both your patch and your commit message, though :-)
>>
>> /D
>>
>> On Wed, Oct 21, 2015 at 11:40:11PM +0200, Guido Lerch wrote:
>> > trashed my subsurface folder and started from scratch today with the
>> last
>> > master @  4722df8
>> >
>> > while building I got a warning
>> >
>> >
>> >
>> > --
>> > Best regards,
>> > Guido
>>
>> > From b1888cc5a96a8fd32b2fa57bfce8f013157df742 Mon Sep 17 00:00:00 2001
>> > From: Guido Lerch <guido.lerch at gmail.com>
>> > Date: Wed, 21 Oct 2015 23:35:41 +0200
>> > Subject: [PATCH] Fixing build warning about freediving
>> >
>> > This just fixes an issue with freediving not being with a switch
>> statement
>> > that was a little annoying.
>> >
>> > location: profice.c
>> > function: plot_string
>> >
>> > Signed-off-by: Guido Lerch <guido.lerch at gmail.com>
>> > ---
>> >  profile.c | 3 +++
>> >  1 file changed, 3 insertions(+)
>> >
>> > diff --git a/profile.c b/profile.c
>> > index 55cf629..4bfb5ff 100644
>> > --- a/profile.c
>> > +++ b/profile.c
>> > @@ -1173,6 +1173,9 @@ static void plot_string(struct plot_info *pi,
>> struct plot_data *entry, struct me
>> >               case AIR:
>> >                       /* nothing */
>> >                       break;
>> > +             case FREEDIVING:
>> > +                     /* nothing */
>> > +                     break;
>> >               }
>> >       }
>> >       if (entry->stopdepth) {
>> > --
>> > 2.3.8 (Apple Git-58)
>> >
>>
>> > _______________________________________________
>> > subsurface mailing list
>> > subsurface at subsurface-divelog.org
>> > http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>>
>>
>
>
> --
> Best regards,
> Guido
>
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151021/da7b1b2e/attachment.html>


More information about the subsurface mailing list