Fixing warning about freediving

Dirk Hohndel dirk at hohndel.org
Thu Oct 22 04:25:29 PDT 2015


On Thu, Oct 22, 2015 at 01:19:37PM +0200, Guido Lerch wrote:
> > 
> >>>> Subject: [PATCH] Fixing build warning about freediving
> >>>> 
> >>>> This just fixes an issue with freediving not being with a switch
> >>> statement
> >>>> that was a little annoying.
> >>>> 
> >>>> location: profice.c
> >>>> function: plot_string
> > 
> > Fixing build warning about freediving
> > 
> > This just fixes an annoying warning that freediving wasn't
> > covered in the switch statement.
> > 
> > 
> > I guess it's a matter of style - I like mine better as it is clear and
> > concise (I hope) :-)
> 
> Hmm to me reads more or less the same. English is not my native language and certainly not as good as yours.
> Keep on correcting ... :-)

I will. To explain a bit more. You say "fixes an issue" - but the code
isn't wrong, there is no "issue". It's just a silly compiler warning. So
we are fixing a warning, not an issue.

/D


More information about the subsurface mailing list