[PATCH] Re: Minor planner bugs

[Dirk Hohndel]

Maybe it's my mail client... but I can't find a patch in this email

/D

On Wed, Oct 21, 2015 at 03:23:46PM +0200, Robert Helling wrote:
> Martin,
> 
> > On 21.10.2015, at 14:27, Martin Měřinský <mermar at centrum.cz <mailto:mermar at centrum.cz>> wrote:
> > 
> > I have no default cylinder preferences. Choosing any cylinder helps. I
> > wasn't aware of the existence of default cylinder :-)
> > 
> > Why there is empty value, in Default cylinder listbox? And why is it
> > default, if it causes such troubles?
> 
> It seems, this never gets initialized properly when it does not come for the stored settings. I don’t know why it is not found when compared to the empty string.
> 
> > 
> >> If there is no default cylinder, it should add an “unknown” cylinder of
> >> 11,1 liter size and 207 bar of air.
> > 
> > This doesn't work.
> 
> Here is a patch that should make this work. Before leaving the function it checks if some cylinder has been defined and does so if not.
> 
> > 
> > After setting default cylinder, I don't get the warning. But still
> > cannot delete some gases, see
> > http://tmp.spvhd.cz/2015-10-21_subsurface_bug_2.ogv <http://tmp.spvhd.cz/2015-10-21_subsurface_bug_2.ogv>
> 
> 
> You cannot delete a gas that is used in the manually entered part of the dive. In the screen cast, you are trying to delete the last air cylinder but that is needed since your bottom time in the profile is on air. I would say, if there is a bug, it is that the trash can is not strike out in that case.
> 
> Best
> Robert
> 
> --
> .oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
> Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
>                       Scientific Coordinator
>                       Ludwig Maximilians Universitaet Muenchen, Dept. Physik
>                       Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
>                       http://www.atdotde.de <http://www.atdotde.de/>
> 
> Enhance your privacy, use cryptography! My PGP keys have fingerprints
> A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
> DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F
> 
> 
> 
> 
> 



> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface