[PATCH] Avoid plotting when ProfileWidget2::plotDive is called speciously.
Robert C. Helling
helling at atdotde.de
Fri Oct 23 14:09:31 PDT 2015
Hi,
> On 23 Oct 2015, at 07:24, K. pestophagous Heller <pestophagous at gmail.com> wrote:
>
> One indirect call site of plotDive, MainTab::acceptChanges, can
> trigger a replot several times during one pass through
> acceptChanges. Avoiding some of the replots is both an
> optimization and a small bug-fix. A replot could happen when
> displayed_dive is presently zeroed-out, which made no sense.
this is a good idea but it is too blunt: With this, when you open the planner on an empty log (I do this quite often when I don’t want any previous dives influence my calculation), you don’t get any plot at all.
So: NAK
Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151023/4dac360d/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151023/4dac360d/attachment.sig>
More information about the subsurface
mailing list