Report error received from zip_close

[Dirk Hohndel]

On Mon, Oct 26, 2015 at 06:13:57PM +1100, Rick Walsh wrote:
> Hi,
> 
> I cannot build Subsurface with commit 8c70635 Report error received from
> zip_close.
> 
> I'm not sure where the type zip_error_t is/should be defined.  I'm running
> Fedora 22.
> 
> [rick at notyourcomputer build]$ make
> [  0%] Built target documentationLink
> [  0%] Built target documentation
> [  0%] Built target link_marble_data
> [  0%] Built target printing_templatesLink
> [  0%] Automatic moc and uic for target subsurface_interface
> [  0%] Built target subsurface_interface_automoc
> [  0%] Built target version
> [  0%] Automatic moc and uic for target subsurface_generated_ui
> [  0%] Built target subsurface_generated_ui_automoc
> [ 15%] Built target subsurface_generated_ui
> [ 16%] Building CXX object
> CMakeFiles/subsurface_interface.dir/qt-ui/subsurfacewebservices.cpp.o
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp: In member
> function ‘bool DivelogsDeWebServices::prepare_dives_for_divelogs(const
> QString&, bool)’:
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:259:3: error:
> ‘zip_error_t’ was not declared in this scope
>    zip_error_t *error = zip_get_error(zip);
>    ^
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:259:16: error:
> ‘error’ was not declared in this scope
>    zip_error_t *error = zip_get_error(zip);
>                 ^
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:259:41: error:
> ‘zip_get_error’ was not declared in this scope
>    zip_error_t *error = zip_get_error(zip);
>                                          ^
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:260:32: error:
> ‘zip_error_code_zip’ was not declared in this scope
>    ze = zip_error_code_zip(error);
>                                 ^
> /home/rick/src/subsurface/qt-ui/subsurfacewebservices.cpp:261:35: error:
> ‘zip_error_code_system’ was not declared in this scope
>    se = zip_error_code_system(error);
>                                    ^
> CMakeFiles/subsurface_interface.dir/build.make:494: recipe for target
> 'CMakeFiles/subsurface_interface.dir/qt-ui/subsurfacewebservices.cpp.o'
> failed
> make[2]: ***
> [CMakeFiles/subsurface_interface.dir/qt-ui/subsurfacewebservices.cpp.o]
> Error 1
> CMakeFiles/Makefile2:1016: recipe for target
> 'CMakeFiles/subsurface_interface.dir/all' failed
> make[1]: *** [CMakeFiles/subsurface_interface.dir/all] Error 2
> Makefile:138: recipe for target 'all' failed
> make: *** [all] Error 2

That's what I get for assuming that libzip has a stable API. Silly, of
course. I'll need to check the specific commit that Lubomir has tested as
known good and see which API is apropriate for this one (and I should
check if there is a way to check at compile time which API is available).

I finally have decent internet - on the flip side I'm now really busy at
the conference :-/

Thanks for the report

/D