[PATCH 1/2] Calculate VPM-B ceiling outside of planner

[Robert C. Helling]

> On 29 Oct 2015, at 12:53, Rick Walsh <rickmwalsh at gmail.com> wrote:
> 
> Comments added to commit

What I already said on IRC:

It should probably be

if (prefs.deco_mode == VPMB && !in_planner() && entry->ceiling >= first_ceiling && first_iteration == true) {


with a good initialisation for first_ceiling so this is true when it is first called (where no ceiling so far has been computed). Otherwise, at least for my real dives, the condition is never true (a breakpoint on the next statement was never reached).

Then, have a look at this file:



This is the same dive planned once with VPM-B and once with Buehlmann 30/80. For the VPM-B the ceiling looks ok. The VPM-B version has a runtime of 55 as compared to that of Buehlmann which has 45. So I would expect to have in the end a TTS of about 10min. But it shows 37min (and a ceiling violation much earlier). Maybe that is what it is. But I am a bit surprised by thus behaviour.

Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151029/e132a152/attachment-0002.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tw35mdiveso.ssrf
Type: application/octet-stream
Size: 8080 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151029/e132a152/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151029/e132a152/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20151029/e132a152/attachment-0001.sig>