[Patch] String translation issues

Dirk Hohndel dirk at hohndel.org
Sat Sep 5 07:06:49 PDT 2015


On Sat, Sep 05, 2015 at 03:55:59PM +0200, Guillaume Gardet wrote:
> Le 05/09/2015 15:53, Dirk Hohndel a écrit :
> >On Sat, Sep 05, 2015 at 12:25:57PM +0300, Lubomir I. Ivanov wrote:
> >>On 5 September 2015 at 12:08, Salvador Cuñat <salvador.cunat at gmail.com> wrote:
> >>>Good morning.
> >>>
> >>>There is a string in qt-ui/btdeviceselectiondialog.cpp which doesn't have a
> >>>good translation:
> >>>
> >>>
> >>>        ui->dialogStatus->setText(tr("The local Bluetooth device was turned
> >>>%1.")
> >>>                                  .arg(on? "ON" : "OFF"));
> >>>
> >>>as "turn on" translates to a word and "turn off" to another.  In other
> >>>languages there will probably be the same issue.
> >>>
> >>>In spanish i've translated to:
> >>>
> >>>        "El dispositivo bluetooth local ha sido %1."
> >>>
> >>>An then translated "ON" to "ACTIVADO" and "OFF" to "DESACTIVADO" but this
> >>>strings should be passed to translation too.
> >>>
> >>hey salva,
> >>yes, ON/OFF should be added for translation as tr("ON"), tr("OFF").
> >I wonder if it wouldn't be better to have
> >
> >ui->dialogStatus->setText(tr("The local Bluetooth device was %1.")
> >	.arg(on ? "turned ON" : "turned OFF")
> 
> With tr() for "turned ON" and "turned OFF".

:facepalm: - of course. That was the point :-)

In my defense, I haven't had coffee, yet.

/D


More information about the subsurface mailing list