[Patch] String translation issues

[Salvador Cuñat]

2015-09-05 16:06 GMT+02:00 Dirk Hohndel <dirk at hohndel.org>:

> > >>>
> > >>hey salva,
> > >>yes, ON/OFF should be added for translation as tr("ON"), tr("OFF").
> > >I wonder if it wouldn't be better to have
> > >
> > >ui->dialogStatus->setText(tr("The local Bluetooth device was %1.")
> > >     .arg(on ? "turned ON" : "turned OFF")
> >
>
Off course it would.


> > With tr() for "turned ON" and "turned OFF".
>
> :facepalm: - of course. That was the point :-)
>
> In my defense, I haven't had coffee, yet.
>

With the strange potion you drink there, there may be no difference.  };-)
And looks like  you applied the patch before the coffee.

Do you want me to rework it ?

Regards.

Salva.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/d4fb4596/attachment.html>