My first patch

[Dirk Hohndel]

OK, working on this some more...

strlcpy isn't available on Windows (and appears not to be there by defauly
on all Linux flavors that I have access to, either... some have it in
bsd/string.h, some don't). So let's use the universally available strncpy
instead.

I removed all the "glerch" markings on your comments. I changed some of
the more annoying variable names but more fixing is needed.

I broke things down into a lot of preparatory patches and the remaining
big logic change.

That last change hasn't received a lot of review and love, yet. I'm
running out of time but I wanted to send out what I have so that others
can comment and so that you, Guido, can take a look at what I did and how
I structured things.

/D



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Uemis-downloader-small-whitespace-change.patch
Type: text/x-diff
Size: 4125 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0010.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Uemis-downloader-various-changes-to-the-debugging-ou.patch
Type: text/x-diff
Size: 4522 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0011.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Uemis-downloader-fix-and-move-helper-function.patch
Type: text/x-diff
Size: 2357 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0012.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Uemis-downloader-add-constant-for-maximum-number-of-.patch
Type: text/x-diff
Size: 1389 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0013.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Uemis-downloader-parse_divespot-should-return-if-it-.patch
Type: text/x-diff
Size: 1735 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0014.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Uemis-downloader-add-helper-function-to-estimate-mem.patch
Type: text/x-diff
Size: 2584 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0015.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Uemis-downloader-parse-dive_no-as-well.patch
Type: text/x-diff
Size: 929 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0016.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Uemis-downloader-add-heler-function-to-delete-dive.patch
Type: text/x-diff
Size: 2031 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0017.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Uemis-downloader-add-helper-function-to-dump-buffer.patch
Type: text/x-diff
Size: 2051 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0018.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Uemis-downloader-change-download-logic.patch
Type: text/x-diff
Size: 18848 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150905/dcca8bf8/attachment-0019.patch>