Bluetooth download - segfault when Choose Bluetooth download mode isn't selected

[Claudiu Olteanu]

Hi there,

Unfortunately I could not reproduce the problem because I don't have a
Petrel device but using the call stack from Rick Walsh I figure out why he
receives a SEGV.
Apparently the return check of  *dc_serial_native_open* method from
*shearwater_common_open* was not correct (my mistake :-) ).
The first patch attached should fix the issue. It should be applied on
Subsurface-branch from libdivecomputer branch.

Also I created two patches which should improve the Subsurface UX. The
scope is to save the user's choice about Bluetooth download mode option
from the last dive computer download session.
In this way, the user doesn't need to open the Bth selection dialog to
choose a dive computer device if it is the same as the one from his last
session.

Claudiu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150907/874c657e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-dc_serial_native_open-return-check-for-Shearwate.patch
Type: text/x-patch
Size: 1194 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150907/874c657e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Save-Bluetooth-download-mode-settings.patch
Type: text/x-patch
Size: 4815 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150907/874c657e/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Reset-the-index-of-the-device-if-the-Bth-mode-is-dis.patch
Type: text/x-patch
Size: 1058 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150907/874c657e/attachment-0002.bin>