"other" tag

[Robert C. Helling]

Hi,

while working on the German translation, I came across the string „other“, which appears in the following code segment in datatrak.c:

        if (byte[0] != 0)
                taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "wreck")));
        if (byte[1] != 0)
                taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "river")));
        if (byte[2] != 0)
                taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "drift")));
        if (byte[3] != 0)
                taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "photo")));
        if (byte[4] != 0)
                taglist_add_tag(&dt_dive->tag_list, strdup(QT_TRANSLATE_NOOP("gettextFromC", "other")));


Does this mean, if byte[4] is non-zero, the dive gets a tag that reads „other“. Is this really what we want? I wouldn’t want to have a dive that has such a tag. What do you think?

Best
Robert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150907/ba1da726/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 496 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150907/ba1da726/attachment.sig>