Uemis patches

[Dirk Hohndel]

On Mon, Sep 07, 2015 at 08:58:39PM +0200, Guido Lerch wrote:
> my result from the learning session with you, I hope you like it.
> 
> the whitespace stuff isnt fixed I am afraid as I dont really know how.

I'm surprised that QtCreator didn't just clean up the whitespace. It's
possible that it only converts whitespace but doesn't address "depth" of
indentation. Anyway, no big deal, I'll clean it up. I'm pretty sure that
all new code that you write from now on will be correctly indented.

> From: glerch <guido.lerch at gmail.com>
> Date: Mon, 7 Sep 2015 20:48:45 +0200
> Subject: [PATCH 1/3] multiple buddy support
> 
> - changed the uemis_add_string to support a delimiter in parameter 3
> - passing each nickname to the parse_tag function appending dive->buddy with concatentated nicknames separaed by comma


That second line is a bit long for a commit message. I'll wrap it for you.

Ignoring the whitespace damage the patch is good. Adding the delimit
parameter is a good way of dealing with this situation.

> From: glerch <guido.lerch at gmail.com>
> Date: Mon, 7 Sep 2015 20:51:49 +0200
> Subject: [PATCH 2/3] original dive number support
> 
> - enabled capturing of the original uemis dive number
> - previousely the object_id was passed to dive as dive number
> - i am using a workaround (not nice but effective) by parsing the dive_no out of a copy of inbuf
>   before the object_id is parsed. The reason why is that the dive_no comes before the object_id
>   hence the normal parsing would miss it.

Again, the commit lines are a bit long. Aim for about 72-76 characters per
line. vim can do that automatically for you :-)

You ended up not putting all of the removal of commented out functions in
their own commit, but again, no big deal.

Thanks for working on this. I'm so glad the Uemis code is finally getting
some attention.

/D