Question about ostc code

Miika Turkia miika.turkia at gmail.com
Wed Sep 9 08:29:02 PDT 2015


I am looking at ostc_prepare_data function and do not fully understand
the code. It looks like in successful case ldc_dat memory allocation
is freed and we end up pointing to unallocated data in our data
structures. However, the failure case ends up leaking memory.

Is the attached patch correct or am I missing something? (I have
nothing to test the code with.)

miika
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-memory-corruption-on-ostc-prepare-data.patch
Type: text/x-diff
Size: 832 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150909/35ba86c0/attachment.patch>


More information about the subsurface mailing list