[PATCH] Exit with failure if dc_open method fails
Anton Lundin
glance at acc.umu.se
Wed Sep 9 23:25:21 PDT 2015
On 09 September, 2015 - Claudiu Olteanu wrote:
> If the dc_serial_*_open method fails then we should exit with
> an error and don't try to open the device using the native
> implementation.
>
> Currently if the local Bluetooth adapter doesn't connect successfully
> to a dive computer it tries to open the device using the native serial
> implementation (libdivecomputer.c: 944 - serial == NULL).
>
> I am not sure how it should work for the serial FTDI implementation if
> it fails. Should it try to open the device again using the old native
> serial
> implementation? Anton?
>
Makes no sense to try to use the native serial if the FTDI variant
fails.
If you're using the FTDI variant, odds are that you don't have a native
serial driver.
Acked-by: Anton Lundin <glance at acc.umu.se>
//Anton
--
Anton Lundin +46702-161604
More information about the subsurface
mailing list