Re[2]: [PATCH] Re: SubSurface Crash When changing a gas in diveplanner graph

[Guido Lerch]

Thanks and thanks :-)
I didnt realize you sent a patch.

G. Lerch


Freitag, 11. September 2015 17:10 +0200 von Robert Helling  <helling at atdotde.de>:
>Guido,
>
>>On 11.09.2015, at 17:06, Guido Lerch < guido.lerch at gmail.com > wrote:
>>
>>You want me to investigate further and provide a patch if I can ?
>
>Happy birthday!
>
>You don’t need to investigate this further since with my last mail I already sent a patch to fix this.
>
>What I wrote was just educational. 
>
>What you write is indeed a possible solution (with the exception of testing for -1 should better be replaced by calling the isValid() method on the index). But then the user would try to change a gas and nothing happens. In my patch, therefore, I make sure the user does not get the list of gases to choose from in the first place when right clicking on the last waypoint.
>
>Best
>Robert
>
>-- 
>.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
>Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
>                      Scientific Coordinator
>                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
>                      Phone:  +49 89 2180-4523   Theresienstr. 39, rm. B339
>                       http://www.atdotde.de
>
>Enhance your privacy, use cryptography! My PGP keys have fingerprints
>A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
>DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F
>
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150912/f5f2a077/attachment.html>