Re[2]: Uemis patch 10-12

[Guido Lerch]

Hi Dirk

That was actually the next thing I am working on after I have fixed a nasty bug that I found after merging two dives together.
Is is Uemis code specific.

I realize the code doesn't read nice but wanted something working before looking at cosmetics.
Retrospectively this was a bad idea as I don't think of that others are going to review.

Thanks for the bday wishes I am back on the code Monday and try to finish all next week.

I have now loaded over 1000 dives successfully using 2 different Uemis and hope the code does the job for others do after I fixed the bug I found this morning.

G. Lerch


Freitag, 11. September 2015 18:28 +0200 von Dirk Hohndel  <dirk at hohndel.org>:
>On Fri, Sep 11, 2015 at 09:12:18AM +0200, Guido Lerch wrote:
>> some code optimisation and cleanup
>
>Thanks, Guido. #10 you had already sent and I pushed it to master
>yesterday. I took #11 and 12 and will push them after some more testing
>here.
>
>One thought. now that you understand the code better, maybe you can
>restructure it to be more readable? The level of indentation is a
>screaming testament to the fact that this needs more helper functions. By
>breaking out parts of the code into functions with good names (even if
>they are used just once) will make the code more readable and more easily
>debuggable.
>
>This is again something that could be done one block at a time. So grab
>something that's way deeply indented. Think of a good name. Create a
>static function and call it from the original spot (making sure the
>functionality is otherwise identical). That's one commit.
>Now do it again for the next block.
>
>And feel free to remove pointless debug output while you do that.
>
>Makes sense?
>
>Oh, and Herzlichen Glückwunsch zum Geburtstag!
>
>/D
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150912/bd62de3d/attachment.html>