[PATCH] Re: Beta Testing - Dive Planner

[Robert Helling]

Hi,

> On 14.09.2015, at 06:38, Robert C. Helling <helling at atdotde.de> wrote:
> 
>> 
>> 3.If I click toggle ruler, a red line appears on my PPO2 line but I dont know what it shows (I looked in manual but its not immediately clearof what it shows). However, if I unclick it it doesn't disappear, that is until I click on another toggle such as scale graph. Funnily enough, if I don't unclick toggle ruler and click scale graph, the red line disappears again.
>> 4.Finally, I ran a buhlmann 100/100 calculation, i would expect the stops to match up with the tissue limits and calculated ceilings (see attached grab). They seem to be out of sync in this example. This of course may be because I don't know what I'm doing :).
> 
> These seem to be related. In fact, it looks like the planner (but not the displayed ceilings) get the setpoint changes wrong. You can tell by for example changing the stepping of the 50m leg of the dive: That affects the ceilings but not the plan.
> 
> Will look at this later today.
> 


here is a patch that fixes these.




There is an unfortunate tradition which apparently goes back to

commit 55b3fd12a8b8c4df4e69ec9d747c77d99b40807a
Author: Dirk Hohndel <dirk at hohndel.org>
Date:   Mon Jan 28 19:54:05 2013 -0800

    Make dive planner more useful for closed circuit diving

that the sample structure contains the setpoint at its _end_ so to find it for a segment we have to evaluate
sample[-1].setpoint.

I tried to get rid of this but failed due to lack of time. This is coded into the source in too many places I could not easily find (with some oldpo2 logic in some places etc etc). So I leave it as this for the moment (this should not be buggy but just a strange convention).

Best
Robert

--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150914/ff50b0a6/attachment-0002.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Use-the-correct-setpoint-in-planner.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150914/ff50b0a6/attachment-0001.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150914/ff50b0a6/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 495 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150914/ff50b0a6/attachment-0001.sig>