[PATCH] VPMB gradient of imperm: don't confuse atm and bar

[Dirk Hohndel]

On Wed, Sep 16, 2015 at 07:57:24PM +1000, Rick Walsh wrote:
> Other VPM-B implementations (V-Planner, MultiDeco, Fortran code) take the
> default gradient of onset of impermeability as 8.2 atm.  We use bar as the
> pressure unit, and 8.2 atm = 8.30865 bar.
> 
> This has negligible effect on all of the calculated plans I've tested, resulting
> in a maximum decrease of 1 minute in total dive time for ~150 m deep dives, but
> we should get unit conversions correct anyway.

I'm not arguing against that. But with this patch TestPlan fails.
So either submit a patch that also adapts the runtime we expect in the
test (and argue why that is the right thing to do), or... 

NAK as it is

/D

> ---
>  deco.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/deco.c b/deco.c
> index 5d3b1d8..ec4501b 100644
> --- a/deco.c
> +++ b/deco.c
> @@ -69,7 +69,7 @@ struct vpmb_config vpmb_config = {
>  	.crit_radius_N2 = 0.55,
>  	.crit_radius_He = 0.45,
>  	.crit_volume_lambda = 199.58,
> -	.gradient_of_imperm = 8.2,
> +	.gradient_of_imperm = 8.30865,		// = 8.2 atm
>  	.surface_tension_gamma = 0.18137175,	// = 0.0179 N/msw
>  	.skin_compression_gammaC = 2.6040525,	// = 0.257 N/msw
>  	.regeneration_time = 20160.0,
> -- 
> 2.4.3
> 
> _______________________________________________
> subsurface mailing list
> subsurface at subsurface-divelog.org
> http://lists.subsurface-divelog.org/cgi-bin/mailman/listinfo/subsurface