testing the Uemis code [was Re: UEMIS-bug fix: fixing the dialog message when the memory us full]

[Dirk Hohndel]

On Thu, Sep 17, 2015 at 12:13:06PM +0200, Guido Lerch wrote:
> >
> >
> weird debug output, you have logfilenr 5, then logfilenr 4 then again
> logfilenr 5 ....

Yes, indeed. Your existing code in master will alternate between those two
files until the memory runs out. Which is because you are comparing the
wrong two values. You compare the # that you ask for with the number that
you want. You never parse (or use) the number that you got:

if (*dive_to_read >= dive->dc.diveid)
	*dive_to_read = (*dive_to_read - 2 >= 0 ? *dive_to_read - 2 : 0);

So in my case where *dive_to_read and dive->dc.diveid are the same this
condition is true the first time and *dive_to_read gets decremented.
The next time around *dive_to_read is smaller and gets incremented.
Then it's the same as the dc.diveid again and gets decremented.

What you need to do instead is basically this:

	uint32_t nr_found = 0;
	char *logfilenr = strstr(mbuf, "logfilenr");
	if (logfilenr)
		sscanf(logfilenr, "logfilenr{int{%u", &nr_found);

So figure out which logfilenr you got and then

	if (nr_found >= dive->dc.diveid)
		*dive_to_read = *dive_to_read - 2;
	if (*dive_to_read < -1) // this will be incremented below so this way we can get to zero
		*dive_to_read = -1;

(easier on the eyes than your :? statement, IMHO)

This way we compare what we found against what we want and decrement what 
we ask for until we get what we want.

> anyway, I think I understand what the difference is with your and my offset
> and will send a patch soon.

Cool.

/D