UEMIS Patch fixing alternating dive details

[Guido Lerch]

2015-09-17 17:26 GMT+02:00 Dirk Hohndel <dirk at hohndel.org>:

> On Thu, Sep 17, 2015 at 08:06:18AM -0700, Dirk Hohndel wrote:
> >
> > Yep, that should work with my Uemis. I'll test it next.
>
> As expected, it seems to work. I'll push this, soon.
>
> One comment.
>
> After every single dive ("details for #xxx) it reads divespot #0. That
> seems completely silly to me. I think I set the divespot on a single dive
> for this Uemis (I find the interface for this completely ridiculous and
> stupid - and why would I ever want to have this on my dive computer if the
> dive computer has no map and no GPS? mind boggles) - anyway, I don't see
> why it would have to read divespots at all - and if it DID have to read
> divespots, then it should read #0 exactly once and remember that it did so
> and not doing it over and over again. This certainly adds to the
> perception that things are going a lot slower now than they used to.
>

In your orignal code it was worse, sorry to say, but you read always all
divespots
with every depending on the diveid.
Next optimization is a real check if the spot is there already and the
omitt the
reading, that's another patch and some work for me tonight and tomorrow.

Hope you are happy with my contributions, even if it's still a little bumpy
:-)

>
> /D
>



-- 
Best regards,
Guido
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150917/26387df2/attachment.html>