UEMIS Patch fixing alternating dive details

[Dirk Hohndel]

On Thu, Sep 17, 2015 at 05:34:06PM +0200, Guido Lerch wrote:
> >
> > After every single dive ("details for #xxx) it reads divespot #0. That
> > seems completely silly to me. I think I set the divespot on a single dive
> > for this Uemis (I find the interface for this completely ridiculous and
> > stupid - and why would I ever want to have this on my dive computer if the
> > dive computer has no map and no GPS? mind boggles) - anyway, I don't see
> > why it would have to read divespots at all - and if it DID have to read
> > divespots, then it should read #0 exactly once and remember that it did so
> > and not doing it over and over again. This certainly adds to the
> > perception that things are going a lot slower now than they used to.
> 
> In your orignal code it was worse, sorry to say, but you read always all
> divespots with every depending on the diveid.

Ha. Since I have only one divespot on my Uemis (see my comment above) that
still meant 10x fewer reads than your code :-)

> Next optimization is a real check if the spot is there already and the
> omitt the reading, that's another patch and some work for me tonight and
> tomorrow.

Cool

> Hope you are happy with my contributions, even if it's still a little bumpy
> :-)

I'm really happy. Bumpy is normal. You are well within the bell curve when
it comes to that.

/D