UEMIS Patch fixing alternating dive details

Dirk Hohndel dirk at hohndel.org
Fri Sep 18 08:35:35 PDT 2015


On Fri, Sep 18, 2015 at 05:26:42PM +0200, Guido Lerch wrote:
> All good now.
> 
> I looked into avoiding to read all the dive-spots but this is not possible
> unless the divespot was read in a current import
> already. The reason on why we cannot compare already stored dives from the
> xml is that we don't store the dive spot
> id. I don't think we should implement this just for the uemis.
> 
> What I am doing already is to avoid duplication of dive spots, and not
> doing anything with dive-spots if the uemus dive-spot
> id is -1. So Dirk, in your case not a single dive-spot is being read :-)
> For me about 80.
> 
> I keep on thinking however on how to make the import faster and allow
> partial imports while I am on vacation :-)
> 
> If someone is testing and finds an issue, please let me know.

So if I read this correctly you think that the current code is "good to
go" for 4.5?

I may make a couple of tiny adjustments here and there (let's call them
"cleanup"), but nothing significant.

I'm planning to release Beta 2 today.

/D


More information about the subsurface mailing list