Re[2]: UEMIS Patch fixing alternating dive details

[Guido Lerch]

Hi Dirk

Keep to see your cleanup, I know I am still struggling to forget about c# :-)

I think the code is good but have a small patch later today, I am still testing. This might avoid a few reads but not a lot.

Over the past two days I read another 10 times all my dives while trying to do some stupid things here and there such as canceling in the middle etc. found no issues but with the Uemis you never know.

Heading out to marsa alam tomorrow , if I find someone with an Uemis I'll read that to if I am allowed. This should give us some more data.

How did the tests with you Uemis go?

G. Lerch


Freitag, 18. September 2015 17:35 +0200 von Dirk Hohndel  <dirk at hohndel.org>:
>On Fri, Sep 18, 2015 at 05:26:42PM +0200, Guido Lerch wrote:
>> All good now.
>> 
>> I looked into avoiding to read all the dive-spots but this is not possible
>> unless the divespot was read in a current import
>> already. The reason on why we cannot compare already stored dives from the
>> xml is that we don't store the dive spot
>> id. I don't think we should implement this just for the uemis.
>> 
>> What I am doing already is to avoid duplication of dive spots, and not
>> doing anything with dive-spots if the uemus dive-spot
>> id is -1. So Dirk, in your case not a single dive-spot is being read :-)
>> For me about 80.
>> 
>> I keep on thinking however on how to make the import faster and allow
>> partial imports while I am on vacation :-)
>> 
>> If someone is testing and finds an issue, please let me know.
>
>So if I read this correctly you think that the current code is "good to
>go" for 4.5?
>
>I may make a couple of tiny adjustments here and there (let's call them
>"cleanup"), but nothing significant.
>
>I'm planning to release Beta 2 today.
>
>/D
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150918/f42cbfc2/attachment.html>