detecting Windows 10 [was: Re: [PATCH] Fix Bluetooth address truncation]

[Dirk Hohndel]

On Sun, Sep 20, 2015 at 09:23:17AM -0700, Thiago Macieira wrote:
> On Sunday 20 September 2015 08:17:07 Dirk Hohndel wrote:
> > On Sun, Sep 20, 2015 at 12:56:43PM +0300, Lubomir I. Ivanov wrote:
> > > On 20 September 2015 at 07:03, Dirk Hohndel <dirk at hohndel.org> wrote:
> > > > On Sun, Sep 20, 2015 at 01:18:00PM +0930, Steve wrote:
> > > >> Thanks Claudiu, these patches fixed the issue perfectly. Both HW OSTC
> > > >> and SW Petrel devices worked well.> > 
> > > > Thanks for verifying! The patches made it to Beta 2, so hopefully we'll
> > > > get some more testing. So far there appears to be only one person who
> > > > has
> > > > tested my Beta 2 binaries, though :-)
> > > > 
> > > > One other thing I notice... I have not a single entry for "Windows 10"
> > > > and
> > > > looking at the code I don't think we have a correct test here.
> > > > 
> > > > Thiago, can you help us out here?
> > > 
> > > here is my quick attempt,
> > > this assumes that Qt 5.5 has the means to find the Windows 10.0
> > > version at runtime. the WINAPI broke the standard GetVersion(Ex) for
> > > versions >= 8.1, but i see that Qt handles that in qglobal.cpp.
> > 
> > I'll try that. We'll see if the next daily detects Win10 correctly.
> 
> That code shouldn't be enabled in Subsurface if you're building with Qt 5.5. 
> The information should come straight from QSysInfo.

:facepalm:

I forgot to upgrade the build server for the Windows binaries to Qt5.5 :-(

Grmbl. Doing that right now... there may be a Beta 3 quicker than expected.

/D