[PATCH] Image time shift calculation

[Robert Helling]

Hi,


I have the impression that up to now, nobody had ever tested the image time shift computation that uses the image of the dive computer to determine the difference between dive computer time and image time. The origin of the problem I found was that Qt uses local time to convert between epoch and date/time while the exif library uses UTC and also our dive times are supposed to be local time but then, when converting to time_t we use UTC.

I have only one test time with meaningful pictures. For this, it works now. But please please somebody else test this. Ideally in a time zone that differs by more than two hours form UTC:

Do a dive and take pictures. Then download the dive to subsurface without changing the dive time manually. Then add the pictures to dive. In the load images dialog, take a picture of your dive computer displaying the time (with the same camera of course) and load that image to that dialog and type in the time displayed by the dive computer on the picture. Does this match the images correctly?

Best
Robert


--
.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oOo.oO
Robert C. Helling     Elite Master Course Theoretical and Mathematical Physics
                      Scientific Coordinator
                      Ludwig Maximilians Universitaet Muenchen, Dept. Physik
                      Phone: +49 89 2180-4523  Theresienstr. 39, rm. B339
                      http://www.atdotde.de

Enhance your privacy, use cryptography! My PGP keys have fingerprints
A9D1 A01D 13A5 31FA 6515  BB44 0820 367C 36BC 0C1D    and
DCED 37B6 251C 7861 270D  5613 95C7 9D32 9A8D 9B8F





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150921/4c5dbe22/attachment-0002.html>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-Fix-image-offset-calculation.txt
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150921/4c5dbe22/attachment-0001.txt>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150921/4c5dbe22/attachment-0003.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 203 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150921/4c5dbe22/attachment-0001.sig>