[PATCH] Image time shift calculation

Dirk Hohndel dirk at hohndel.org
Mon Sep 21 10:27:37 PDT 2015


On Mon, Sep 21, 2015 at 05:54:06PM +0200, Robert Helling wrote:
> 
> Hi,
> 
> 
> I have the impression that up to now, nobody had ever tested the image
> time shift computation that uses the image of the dive computer to
> determine the difference between dive computer time and image time. The
> origin of the problem I found was that Qt uses local time to convert
> between epoch and date/time while the exif library uses UTC and also our
> dive times are supposed to be local time but then, when converting to
> time_t we use UTC.

That's interesting. I know that when this first was implemented I tested
it. I will test it again on my upcoming dive trip next week.

I'll take your patch for obvious reasons but I'd really encourage others
to test this (and most everything else in Subsurface) as well.

We need much better automated testing. Much much better.

/D


More information about the subsurface mailing list