cmake -DMARBLE_INCLUDE_DIR broken?

[Gaetan Bisson]

[2015-09-23 19:46:54 -1000] Gaetan Bisson:
> [2015-09-23 20:04:56 -0700] Dirk Hohndel:
> > On Wed, Sep 23, 2015 at 07:58:02PM -0700, Dirk Hohndel wrote:
> > > On Wed, Sep 23, 2015 at 04:36:45PM -1000, Gaetan Bisson wrote:
> > > > [2015-09-23 15:53:59 -1000] Gaetan Bisson:
> > > > > Ah, that second issue goes away (and subsurface builds fine) when I add
> > > > > the cmake option -DMARBLE_LIBRARIES=/usr/lib/libssrfmarblewidget.so .
> > > > 
> > > > Oh, now I'm getting a segfault when I edit any dive and click "Apply Changes".
> > > 
> > > Hehe, I can confirm that. I was so busy testing the location handling that
> > > I apparently didn't notice that something that went in today broke basic
> > > editing.
> > > 
> > > I'll look into it.
> > 
> > OK, I think I fixed this. Please try again with the latest master.
> 
> Thanks so much for looking into this. Unfortunately it seems the bug is
> still there with the latest master. I'll try to debug this and send a
> more helpful report.

Here is a non-stripped backtrace with the latest master; is it normal
for copy_dive_site's first argument to be NULL?

Program received signal SIGSEGV, Segmentation fault.
copy_dive_site (orig=0x0, copy=0x999b00 <displayed_dive_site>) at /opt/arch/aur/subsurface-git/src/subsurface/divesite.c:241
241             copy->latitude = orig->latitude;
(gdb) bt
#0  copy_dive_site (orig=0x0, copy=0x999b00 <displayed_dive_site>) at /opt/arch/aur/subsurface-git/src/subsurface/divesite.c:241
#1  0x00000000005903c6 in MainTab::updateDiveSite (this=this at entry=0xc01a40, divenr=<optimized out>) at /opt/arch/aur/subsurface-git/src/subsurface/qt-ui/maintab.cpp:887
#2  0x00000000005974ed in MainTab::acceptChanges (this=<optimized out>) at /opt/arch/aur/subsurface-git/src/subsurface/qt-ui/maintab.cpp:1048
#3  0x000000000055739d in MainTab::qt_static_metacall (_o=<optimized out>, _c=<optimized out>, _id=<optimized out>, _a=<optimized out>) at /opt/arch/aur/subsurface-git/src/subsurface/moc_maintab.cpp:253
#4  0x00007ffff026ffea in QMetaObject::activate(QObject*, int, int, void**) () from /usr/lib/libQt5Core.so.5
#5  0x00007ffff12213d2 in QAction::triggered(bool) () from /usr/lib/libQt5Widgets.so.5
#6  0x00007ffff1223878 in QAction::activate(QAction::ActionEvent) () from /usr/lib/libQt5Widgets.so.5
#7  0x00007ffff1329900 in ?? () from /usr/lib/libQt5Widgets.so.5
#8  0x00007ffff1329a34 in QAbstractButton::mouseReleaseEvent(QMouseEvent*) () from /usr/lib/libQt5Widgets.so.5
#9  0x00007ffff13ee17a in QToolButton::mouseReleaseEvent(QMouseEvent*) () from /usr/lib/libQt5Widgets.so.5
#10 0x00007ffff126df08 in QWidget::event(QEvent*) () from /usr/lib/libQt5Widgets.so.5
#11 0x00007ffff13ee259 in QToolButton::event(QEvent*) () from /usr/lib/libQt5Widgets.so.5
#12 0x00007ffff122b00c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5
#13 0x00007ffff1230be9 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5
#14 0x00007ffff024189b in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib/libQt5Core.so.5
#15 0x00007ffff122faf2 in QApplicationPrivate::sendMouseEvent(QWidget*, QMouseEvent*, QWidget*, QWidget*, QWidget**, QPointer<QWidget>&, bool) () from /usr/lib/libQt5Widgets.so.5
#16 0x00007ffff128874b in ?? () from /usr/lib/libQt5Widgets.so.5
#17 0x00007ffff128acfb in ?? () from /usr/lib/libQt5Widgets.so.5
#18 0x00007ffff122b00c in QApplicationPrivate::notify_helper(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5
#19 0x00007ffff12304e6 in QApplication::notify(QObject*, QEvent*) () from /usr/lib/libQt5Widgets.so.5
#20 0x00007ffff024189b in QCoreApplication::notifyInternal(QObject*, QEvent*) () from /usr/lib/libQt5Core.so.5
#21 0x00007ffff0a50c81 in QGuiApplicationPrivate::processMouseEvent(QWindowSystemInterfacePrivate::MouseEvent*) () from /usr/lib/libQt5Gui.so.5
#22 0x00007ffff0a52955 in QGuiApplicationPrivate::processWindowSystemEvent(QWindowSystemInterfacePrivate::WindowSystemEvent*) () from /usr/lib/libQt5Gui.so.5
#23 0x00007ffff0a37e08 in QWindowSystemInterface::sendWindowSystemEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Gui.so.5
#24 0x00007fffe23029f0 in ?? () from /usr/lib/libQt5XcbQpa.so.5
#25 0x00007fffebe199fd in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#26 0x00007fffebe19ce0 in ?? () from /usr/lib/libglib-2.0.so.0
#27 0x00007fffebe19d8c in g_main_context_iteration () from /usr/lib/libglib-2.0.so.0
#28 0x00007ffff029823f in QEventDispatcherGlib::processEvents(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5
#29 0x00007ffff023f26a in QEventLoop::exec(QFlags<QEventLoop::ProcessEventsFlag>) () from /usr/lib/libQt5Core.so.5
#30 0x00007ffff024720c in QCoreApplication::exec() () from /usr/lib/libQt5Core.so.5
#31 0x00000000004946e0 in main (argc=1, argv=<optimized out>) at /opt/arch/aur/subsurface-git/src/subsurface/main.cpp:78

-- 
Gaetan