[PATCH] VPM-B set default conservatism +3

Rick Walsh rickmwalsh at gmail.com
Sun Sep 27 04:28:26 PDT 2015


Hi,

On 27 September 2015 at 20:44, Dirk Hohndel <dirk at hohndel.org> wrote:

> While I don't disagree that we should have conservative default settings,
> this is one of those cases where I want to poke at people a bit to use our
> test tools before submitting patches.
>
> Sorry, I have no excuse to have overlooked the tests with this change.


> With this patch applied, unsurprisingly all the VPM-B plan tests now fail.
> That's what those tests are supposed to track.
>
> So I'm not opposed to this patch. But it needs a companion patch that
> updates the tests, please.
>
>
1 line companion patch attached.  As the benchmarks use nominal (zero)
conservatism, we should still use that for the tests, not update the tests
to use +3 conservatism.

Cheers,

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150927/4465cdd7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-TestPlan-Set-VPM-B-conservatism-to-zero.patch
Type: text/x-patch
Size: 797 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20150927/4465cdd7/attachment.bin>


More information about the subsurface mailing list