[PATCH] Copy coordinates when renaming site

[Dirk Hohndel]

On Thu, Apr 14, 2016 at 07:51:54PM -0700, Linus Torvalds wrote:
> On Thu, Apr 14, 2016 at 12:39 PM, Miika Turkia <miika.turkia at gmail.com> wrote:
> > Let's not discard our GPS location when editing site name on mobile.
> 
> This on the face of it sounds "obviously correct", but the fact is, it's not.
> 
> Not obvious, that is.
> 
> It might be correct, but it might also not be.
> 
> What if you picked the wrong dive site first, got the gps coordinates
> from having picked the wrong name, and then you fix the name, not
> realizing you now have completely bogus gps coordinates just because
> of the intermediate temporary wrong pick.
> 
> In other words - changing the name of the dive site in no way means
> that we should automatically pick up the old gps information.

Ahh - but this is the mobile UI, not the desktop UI. So the situation here
is a tad different because it doesn't do the whole "dive sites are
miraculous wonders of endless confusion" thing. You simply have applied
your GPS coordinates to your dives. And now you enter the name of the dive
site. And that damn well better not discard the GPS coordinates.

So this does indeed seem to be the obviously correct behavior as far as I
am concerned.

/D