[PATCH] Copy coordinates when renaming site

[Dirk Hohndel]

> On Apr 14, 2016, at 8:53 PM, Linus Torvalds <torvalds at linux-foundation.org> wrote:
> 
> On Thu, Apr 14, 2016 at 8:41 PM, Dirk Hohndel <dirk at hohndel.org> wrote:
>> 
>> 
>> Since we don't autocomplete dive sites on mobile... what behavior do
>> you think is the expected behavior if you are on mobile, you have an
>> old dive at "Turle Reef" in Maui, with GPS data, and you realize that
>> this should of course be "Turtle Reef".
>> 
>> I would assume that you'd want the GPS to stay and the name to be
>> updated.
> 
> You're making up a scenario where that is true.
> 
> But my point was that there are equally good other cases where it wasn't.
> 
> If you're fixing a spelling error, then _of_course_ you want the gps to stay.
> 
> But if you're editing up the fact that you picked the wrong dive site entirely?
> 
> The thing is, I absolutely DETEST this "gps is magic" shit. It's wrong.

After a year I still am not in love with that whole dive site notion, either.
But it appears to be what many users want.

So what this means is that the way we deal with it in our UI is still broken.
And you are correct, it's broken in different way between desktop and 
mobile version which potentially makes this even worse. :-(

So should I hold back the next Android release / first iOS release until
we have a better UI for this?

And how would that UI look, btw? What would be a reasonable way
to deal with GPS coordinates on a mobile device?

Here's where I sit. You dump your hate for the way we do this on me.
Yet I don't see what would be a better way to do this. I can throw my
hands up in the air and say "hey, I'll wait for Linus' patches" but I'm
pretty sure that will be a long wait.

So we can agree that we absolutely hate the current user experience
in Subsurface 4.5.x - it's utter bullshit. And that is NOT Tomaz' fault.
He tried over and over and over, implemented five different UIs for it.
And it's still bullshit.

And I can see how the combination of what we do on the desktop and
what we do on mobile is also potentially very confusing.

But what SHOULD we be doing?

/D