Kirigami patches

[Tomaz Canabrava]

Subsue

Em 16 de ago de 2016 04:43, "Marco Martin" <notmart at gmail.com> escreveu:
>
> On Tuesday 16 August 2016, Martin Gysel wrote:
> > Am 16.08.2016 um 01:55 schrieb Dirk Hohndel:
> > > It's pretty clear that no one ever tested the kirigami.pro qmake file.
> > > The second patch I'm not 100% sure about, but it seems to match what
the
> > > documentation tells us SHOULD be done.
> >
> > maybe my understanding of the qt build system, tools and libraries is
> > wrong, but wouldn't it be better to
> >
> > - use the .pri file when directly linking in kirigami into the (parent)
> > project (include directive in PROJECT.pro), then the Q_INIT_RESOURCE is
> > not necessary. using qmake this seems to be the easiest way and at least
> > seems to compile for different platforms.
>
> subsurface is cmake based, so the pri file can't be used

Subsurface is cmake based only on all platforms besides ios, I didn't
managed to make the ios build work on cmake.

> > - use the .pro file when using kirigami as library/plugin (static or
> > dynamic, from a parent 'subdirs' pro file). then the static variant
> > needs the Q_INIT_RESOURCE. using this approach leads at least on iOS to
> > various problems linking the app and not finding the resources at
> > runtime (so it did so while I tested this)
> >
> > this also means we probably need another define like
> > KIRIGAMI_BUILD_TYPE_STATIC_PLUGIN and/or
KIRIGAMI_BUILD_TYPE_DYNAMIC_PLUGIN
>
> why the one define used right now wouldn't be enough?
>
> --
> Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160816/2a7d7c81/attachment.html>