preferences - safe to merge (finally)

Tomaz Canabrava tcanabrava at kde.org
Sat Aug 27 04:58:08 PDT 2016


sorry for the long delay - life is a bit crazy.

For those who don't know yet, I'm trying to move to germany and I just went
to the consulate here in brazil this tuesday - send me good vibes.

While this is mostly finished and a *bit* tested, I didn't do a ton of
testing, so I'll send more patches over those, but this is a goos start, if
I break anything on any preferences - you'd been warned, not finished, but
mergeable.
I'd say this is 80% ready. I'v foud a few places where a setting is changed
the 'wrong' way (and by wrong way I mean that a setting is changed, the
setting should trigger code but some unrelated signal is send that in turn
will trigger the correct code. But the signal (or the class) shouldn't be
doing that)

Tomaz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-General-Settings-use-the-SettingsObjectHelper.patch
Type: text/x-patch
Size: 3137 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0023.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Make-georeference-use-the-SettingsObjectHelper.patch
Type: text/x-patch
Size: 2063 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0024.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Preferences-Graph-using-the-SettingsObjectWrapper.patch
Type: text/x-patch
Size: 3622 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0025.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Use-internal-prefs-structure-to-read-preferences.patch
Type: text/x-patch
Size: 2252 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0026.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-Save-the-language-settings-using-the-wrapper.patch
Type: text/x-patch
Size: 2795 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0027.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-Save-user-id-local-seems-to-be-a-bit-of-a-mess.patch
Type: text/x-patch
Size: 9882 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0028.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-Preferences-settings-redone.patch
Type: text/x-patch
Size: 4338 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0029.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0008-Rework-units.patch
Type: text/x-patch
Size: 2515 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0030.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0009-Update-manager-to-settings.patch
Type: text/x-patch
Size: 6552 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0031.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0010-Simplify-Update-Manager.patch
Type: text/x-patch
Size: 3822 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0032.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0011-Removed-unused-include-variable.patch
Type: text/x-patch
Size: 940 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0033.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0012-Move-Dive-Computer-settings-to-the-Settings.patch
Type: text/x-patch
Size: 16023 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0034.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0013-Remove-unused-include.patch
Type: text/x-patch
Size: 1070 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0035.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0014-Correct-usage-of-QSettings.patch
Type: text/x-patch
Size: 934 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0036.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0015-Removed-a-bunch-of-uneeded-includes.patch
Type: text/x-patch
Size: 5274 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0037.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0016-Some-code-cleanup.patch
Type: text/x-patch
Size: 2026 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0038.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0017-Simplify-code-by-using-the-SettingsObjectHelper.patch
Type: text/x-patch
Size: 1178 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0039.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0018-Fix-Facebook-Widget-to-use-the-SettingsObjectWrapper.patch
Type: text/x-patch
Size: 6789 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0040.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0019-Move-preferences-sync-initialization.patch
Type: text/x-patch
Size: 8407 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0041.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0020-Organize-the-connect-calls-per-object.patch
Type: text/x-patch
Size: 4526 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0042.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0021-Use-the-Settings-to-store-the-plannersettings.patch
Type: text/x-patch
Size: 2936 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0043.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0022-Move-loadPreferences-out-of-qt-helper.cpp.patch
Type: text/x-patch
Size: 16780 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0044.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0023-Remember-to-load-the-updater-settings.patch
Type: text/x-patch
Size: 1167 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160827/682e79d1/attachment-0045.bin>


More information about the subsurface mailing list