TestParse failure

Tomaz Canabrava tcanabrava at kde.org
Tue Dec 27 04:50:17 PST 2016


Here you go.

I didn't actually fixed the testcases with those patches because I have no
idea how saving / resroring works, but this makes it really easier to spot
the errors, that actually where real errors.

The error output now are two:
   Actual   (readin.takeFirst()) : "  <divecomputer>"
   Expected (written.takeFirst()): "  <divecomputer model='csv'
deviceid='ffffffff'>"
   Loc: [/home/tcanabrava/Projects/subsurface/tests/testparse.cpp(125)]

FAIL!  : TestParse::testParseCompareHUDCOutput() Compared values are not
the same
   Actual   (readin.takeFirst()) : "</divesites>"
   Expected (written.takeFirst()): "<site uuid='deadbeef' name='Suomi -  -
H\u00E4lv\u00E4l\u00E4'>"
   Loc: [/home/tcanabrava/Projects/subsurface/tests/testparse.cpp(221)]


seems that we are not saving the divecomputer for csv, and we miss some
divesites.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20161227/cfbec3dd/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Test-line-by-line-for-equality-on-Test.patch
Type: text/x-patch
Size: 3135 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20161227/cfbec3dd/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Correctly-open-the-resource-file.patch
Type: text/x-patch
Size: 1725 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20161227/cfbec3dd/attachment-0001.bin>


More information about the subsurface mailing list