[PATCH 4/3] Document quirks with Ostc 4 versions

Anton Lundin glance at acc.umu.se
Wed Dec 28 12:06:54 PST 2016


Signed-off-by: Anton Lundin <glance at acc.umu.se>
---
 desktop-widgets/configuredivecomputerdialog.cpp | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/desktop-widgets/configuredivecomputerdialog.cpp b/desktop-widgets/configuredivecomputerdialog.cpp
index 6c1d44d..1e8c9e7 100644
--- a/desktop-widgets/configuredivecomputerdialog.cpp
+++ b/desktop-widgets/configuredivecomputerdialog.cpp
@@ -261,8 +261,11 @@ void OstcFirmwareCheck::checkLatest(QWidget *_parent, device_data_t *data)
 	if (latestFirmwareAvailable.isEmpty())
 		return;
 
-	// for now libdivecomputer gives us the firmware on device undecoded as integer
+	// libdivecomputer gives us the firmware on device as an integer
 	// for the OSTC that means highbyte.lowbyte is the version number
+	// For OSTC 4's there is actually a another minor, x.y.Z, but its not
+	// exposed via libdivecomputer, so we won't trigger this update flow
+	// when the Z changes
 	int firmwareOnDevice = devData.libdc_firmware;
 	QString firmwareOnDeviceString = QString("%1.%2").arg(firmwareOnDevice / 256).arg(firmwareOnDevice % 256);
 
-- 
2.9.3



More information about the subsurface mailing list