[torvalds/subsurface] QWebEngine and fix for images from web (#128)

Dirk Hohndel dirk at hohndel.org
Fri Dec 30 14:19:26 PST 2016


This is the big problem with saying "we move to github".
There are way too many "Subsurface" repositories there.

Robert, please make pull requests to
https://github.com/Subsurface-divelog/subsurface

Linus, would you have a problem with either deleting your repository or
putting a bot there that auto-closes all pull requests? Unfortunately,
GitHub very very intentionally and explicitly does not provide a way to
turn off pull requests on repos :-( 

Thanks

/D

On Fri, Dec 30, 2016 at 10:54:37AM -0800, Robert C. Helling wrote:
> This is a pull request for two patches that I already sent to the mailing list: 
> 
> 1) The start of the transition from QWebKit to QWebEngine configurable with a CMake variable
> 
> 2) A fix for treatment of images downloaded from the web (this was sent earlier but was apparently forgotten).
> You can view, comment on, or merge this pull request online at:
> 
>   https://github.com/torvalds/subsurface/pull/128
> 
> -- Commit Summary --
> 
>   * Start transition from QWebKit to QWebEngine
>   * Fix picture hashing logic for pictures on the web.
> 
> -- File Changes --
> 
>     M CMakeLists.txt (1)
>     M cmake/Modules/HandleUserManual.cmake (11)
>     M core/imagedownloader.cpp (2)
>     M core/qthelper.cpp (6)
>     M desktop-widgets/plugins/facebook/facebookconnectwidget.cpp (17)
>     M desktop-widgets/plugins/facebook/facebookconnectwidget.h (8)
>     M desktop-widgets/printer.cpp (40)
>     M desktop-widgets/printer.h (8)
>     M desktop-widgets/usermanual.cpp (45)
>     M desktop-widgets/usermanual.h (36)
> 
> -- Patch Links --
> 
> https://github.com/torvalds/subsurface/pull/128.patch
> https://github.com/torvalds/subsurface/pull/128.diff
> 
> -- 
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly or view it on GitHub:
> https://github.com/torvalds/subsurface/pull/128


More information about the subsurface mailing list