Crash Mobile build 758 on Android 5.1.1

[Rick Walsh]

On 1 February 2016 at 17:10, Joakim Bygdell <j.bygdell at gmail.com> wrote:

>
> > On 31 Jan 2016, at 21:02, Dirk Hohndel <dirk at hohndel.org> wrote:
> >
> >
> >> On Jan 31, 2016, at 11:55 AM, Willem Ferguson <
> willemferguson at zoology.up.ac.za> wrote:
> >>
> >> On 31/01/2016 21:29, Dirk Hohndel wrote:
> >>> On Sun, Jan 31, 2016 at 09:23:48PM +0200, Willem Ferguson wrote:
> >>>> Ok, 675 works and 676 crashes.
> >>>> Hope this helps a bit?
> >>> It should.
> >>>
> >>> Please try -763
> >>>
> >> 763 Working perfectly.
> >
> > Excellent. So now we need to figure out how to move the dive # up again
> so we don't run out of space...
> > Patches welcome :-)
> By reverting that old commit you once agin introduced the problem with a
> column being to wide for the device screen,
> for me the profile is slightly wider (no right hand margin) which leads to
> a truncation on the last digit of the dive #.
>
> Looking at the code changes the only thing that pops out for me, and that
> have proven to be problematic before is that
> when the drive # was in the top row it was right aligned while all the
> other objects in the 4:th column does not have any alignment reference.
> It might be worth a try to revert cba50ec and remove the alignment
> specification of the dive #.
>

I can't reproduce it, but I think it might be due to the date text field
getting too long for its two columns spans. It might be being thrown by the
right-aligned dive number, but why would it only affect two users? David
has a Samsung running Android 5.1.1, and had to issues. My phone (Galaxy
S6) is also Samsung running Android 5.1.1, but I can't reproduce the crash.
Something is odd anyway.

I submitted a patch that moves the dive number back up, wraps the text
fields, and doesn't right-align the dive number. I'm hoping that covers all
bases.

Please test, especially Willem and David, who were the ones that could
create the issue. Out of curiosity, how is the date and time displayed on
your devices? Is it possible that the locale is making the date longer than
it is for the rest of us? My last dive's date is displayed as 'Sat 30 Jan
2016 12:31 PM'. I doubt that's the cause, because David's log says his
locale is en-GB, which I expect would be similar to my en-AU. Obviously,
spelling out the full day, month, or including seconds would make a
significant difference.

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160201/ed3c5602/attachment-0001.html>