[PATCH] MOBILE. Update downloadfromdivecomputer: screen 2nd attempt

Dirk Hohndel dirk at hohndel.org
Tue Feb 2 09:33:07 PST 2016


On Tue, Feb 02, 2016 at 08:09:59AM +0200, Willem Ferguson wrote:
> On 02/02/2016 03:59, Dirk Hohndel wrote:
> >Whitespace :-(
> >I really can't tell easily what you changed.
> >It's usually a good idea to take a look at your patch before you send it
> >and ask yourself... "are these the changes that I made, or is something
> >else going on"?
> 
> Apologies. it was a confusion of versions after messing up with vim during a
> commit.

:-)

> Subject: [PATCH 3/3] [PATCH] Mobile. Update downloadfromdivecomputer screen.
> 
> 1) Insert spacer to make space for silly button at screen bottom.
> 2) Adjust column widths of table of downloaded dives.
> 3) Simplification and general cleanup of QML code for this page.
> 
> Signed-off-by: Willem Ferguson<willem at localhost.localdomain>

I hate to be a pain. Really. But that email address? Not so sure that's
what you wanted. And sadly, the patch doesn't apply to latest master. And
given that this file hasn't been touched by anyone since your last commit
on 1/25... my guess is that something got mixed up on your computer...

May I ask you for another attempt against a clean master?

Thanks

/D


More information about the subsurface mailing list