punch list for public beta of Subsurface-mobile for Android

[Dirk Hohndel]

On Fri, Feb 05, 2016 at 05:01:16PM +0100, Marco Martin wrote:
> 
> is it now using the components from master?

Latest I have is
commit 42c55621a4b99916220d68052f85df6735b7c20b
Author: Dan Leinir Turthra Jensen <admin at leinir.dk>
Date:   Wed Feb 3 12:32:11 2016 +0000

    Make the (physical) back button work again for the application window's pagestack


> maybe for the first release the attached patch should be used until we figure 
> out what't broken in keyboard management in Android
> 
> -- 
> Marco Martin

> diff --git a/components/mobilecomponents/qml/ApplicationWindow.qml b/components/mobilecomponents/qml/ApplicationWindow.qml
> index c71c4e9..8b6342e 100644
> --- a/components/mobilecomponents/qml/ApplicationWindow.qml
> +++ b/components/mobilecomponents/qml/ApplicationWindow.qml
> @@ -131,7 +131,6 @@ ApplicationWindow {
>          id: __pageStack
>          anchors {
>              fill: parent
> -            bottomMargin: Qt.inputMethod.keyboardRectangle.height
>          }
>          focus: true
>          Keys.onReleased: {


I can find that code but what concerns me... in my copy (from master, see
above), that's line 63, not line 134 as in your diff. Am I pulling from
the wrong repo? I have git://github.com/KDE/plasma-mobile and a quick
check online at
https://github.com/KDE/plasma-mobile/blob/master/components/mobilecomponents/qml/ApplicationWindow.qml
confirms what I see... this is line 63.

So... did you forget to push something that should be upstream but isn't?


/D