[PATCH 2/2] Adding about page to Subsurface-mobile

Dirk Hohndel dirk at hohndel.org
Wed Feb 10 10:25:15 PST 2016


> On Feb 10, 2016, at 9:50 AM, Miika Turkia <miika.turkia at gmail.com> wrote:
> 
> On Wed, Feb 10, 2016 at 5:29 PM, Sebastian Kügler <sebas at kde.org> wrote:
>> On Wednesday, February 10, 2016 05:09:51 PM Miika Turkia wrote:
>>> +import QtQuick.Window 2.2
>>> +import QtQuick.Dialogs 1.2
>> 
>> Seems unused?
>> 
>>> +       signal accept
>> 
>> What is this used for?
> 
> I am quite clueless when it comes to QML so I am quite sure these can
> be removed. Some leftover from the Preferences.qml that I used as
> starting point.

That's how most of my code gets written. Copy from somewhere else and
start making modifications...
> 
>> Could you attach or link a screenshot to this page? That makes it much easier
>> to review the visual aspects.
> 
> Here is a screenshot. I'll do the suggested changes if others agree
> that it makes sense to have an  About window.

Yes.

With apologies to Willem. Once again we are doing things in the wrong order.
We shouldn't be making such fundamental changes this late. Speaking of which,
based on Jocke's very reasonable feedback I'm re-doing the StartPage in a way
that makes much more sense to me.

Again something I should have done weeks ago, but I was way too focused on 
trying to get all those silly bugs fixed.

> BTW how do I access the splash image on the Image tag (or what these
> should be called in QML)? I was trying to use the bigger logo image,
> but couldn't figure out how to access it.

I'm not quite sure what you mean. How to access the resources? Look at
TopBar.qml - it shows you how to use an Image and how to reference the
file in the resources. If you need to add a different one, just add it to the
mobile-resource.qrc file

/D


More information about the subsurface mailing list