[PATCH 0/3] fix printing regressions
Dirk Hohndel
dirk at hohndel.org
Mon Feb 29 09:01:50 PST 2016
> On Feb 29, 2016, at 8:59 AM, Lubomir I. Ivanov <neolit123 at gmail.com> wrote:
>
> On 29 February 2016 at 18:57, Dirk Hohndel <dirk at hohndel.org> wrote:
>>
>>> On Feb 29, 2016, at 7:35 AM, Dirk Hohndel <dirk at hohndel.org> wrote:
>>>
>>> On Mon, Feb 29, 2016 at 04:42:05PM +0200, Lubomir I. Ivanov wrote:
>>>> From: "Lubomir I. Ivanov" <neolit123 at gmail.com>
>>>>
>>>> i went with the route of adding a HTML preprocession stage like Dirk suggested,
>>>> instead of adding all the "dummy" properties and methods in DiveObjectHelper
>>>> to fix the regressions.
>>>
>>> Excellent. I'm glad this worked.
>>>
>>>> NOTE: i remember that there were some annoying Grantlee breakages on OSX,
>>>> so it would be best if this is tested on all target OS. i don't have builds
>>>> on OSX and Linux, so only tested (and works) on Win32!
>>>
>>> I'll trigger daily builds including Mac (which I haven't built on in ages,
>>> so these may take a while to get to the point where they actually work -
>>> please keep poking me until I have them done...)
>>
>> Mac build is up and seems to be working.
>>
>> Quick question: should this go into 4.5.4 as well? Given that it interacts with the
>> new Dive object helper I wasn't sure how to deal with that...
>>
>
> if the new DiveHelperObject class goes into the new release, then
> these patches should be included as well.
No it doesn't. So the inverse is true as well?
/D
More information about the subsurface
mailing list