[PATCH] Small changes to the profile

Joakim Bygdell j.bygdell at gmail.com
Tue Jan 5 07:59:12 PST 2016


> On 05 Jan 2016, at 16:56, Dirk Hohndel <dirk at hohndel.org> wrote:
> 
> 
>> On Jan 5, 2016, at 6:25 AM, Joakim Bygdell <j.bygdell at gmail.com> wrote:
>> 
>> Due to the small screen of mobile devices,
>> the positions of the temperature graph and the dive computer name
>> needs to be shifted upwards a bit to prevent them from overlapping with the
>> time axis.
>> 
>> Signed-off-by: Joakim Bygdell <j.bygdell at gmail.com>
>> ---
>> profile-widget/profilewidget2.cpp | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>> diff --git a/profile-widget/profilewidget2.cpp b/profile-widget/profilewidget2.cpp
>> index 63ce51f..5e69d2e 100644
>> --- a/profile-widget/profilewidget2.cpp
>> +++ b/profile-widget/profilewidget2.cpp
>> @@ -426,7 +426,7 @@ void ProfileWidget2::setupItemSizes()
>> 
>> 	// Temperature axis config
>> 	itemPos.temperature.pos.on.setX(3);
>> -	itemPos.temperature.pos.on.setY(60);
>> +	itemPos.temperature.pos.on.setY(50);
> 
> Should that change be SUBSURFACE_MOBILE specific as well? I know that we
> fiddled with this a long time to make things work for most dives on the desktop
> version - I'm a bit hesitant to just change this unless that has received some
> intense testing on the desktop and is deemed overall an improvement.

I checked with the desktop version and it only has an effect if the temperature graph is the only visible object in the profile, but for consistency it is an quick fix.

> 
> /D

/Jocke



More information about the subsurface mailing list