Patches regarding subsurface-mobile

Tomaz Canabrava tcanabrava at kde.org
Fri Jan 8 07:10:02 PST 2016


On Fri, Jan 8, 2016 at 1:04 PM, Lubomir I. Ivanov <neolit123 at gmail.com>
wrote:

> On 8 January 2016 at 17:02, Tomaz Canabrava <tcanabrava at kde.org> wrote:
> >
> >
> > On Fri, Jan 8, 2016 at 1:00 PM, Lubomir I. Ivanov <neolit123 at gmail.com>
> > wrote:
> >>
> >> On 8 January 2016 at 16:48, Tomaz Canabrava <tcanabrava at kde.org> wrote:
> >> > Dirk asked for a reworked set of patches, here they are.
> >>
> >> + Q_PROPERTY(QStringList weights READ weights CONSTANT)
> >> + Q_PROPERTY(QStringList cylinders READ cylinders CONSTANT)
> >>
> >> is it still possible to get cylinder0 - cylinderN and
> >> wieght0...weigthN as Grantlee variables?
> >
> >
> > I tested the grantlee printings and didn't found anything wrong, I may
> have
> > missed something,
> > but I think it supports it.
> >
>
> i'm asking because, i don't see the support for the xxx0-N variables,
> which is even documented, but mind that these are not used in the
> bundled templates.
> if these are broken then the patches cause a regression.
>

well - I'll ask to apply the patches anyhow, and I'll create a test
template to test for cylinder / weigths 0-8
I do belive it works because http://www.grantlee.org/apidox/for_app_dev.html
shows some support for lists, and QStringList is just a typedef for
QList<QString>



>
> good direction with the refactoring, though.
>
> lubomir
> --
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160108/64571eef/attachment.html>


More information about the subsurface mailing list