[PATCH] QML UI DiveDetailsView: shift dive number to right of top row

Rick Walsh rickmwalsh at gmail.com
Tue Jan 19 01:43:25 PST 2016


On my phone at least, the dive number gets cropped when viewing a dive.  It
is especially bad for dives of one hour or more, where the duration text
takes up a few extra characters.  By shifting the dive number up a row, so
it follows the date, the display looks much better.  The attached patch
does that, and as shown in the attached screenshots.

To make space for the dive number, the date grid item is reduced from 3
columns (i.e. 3/4 of the screen width) to 2 columns (1/2 the screen
width).  I can't see this being a problem, but I haven't tested any other
locales or devices.

Cheers,

Rick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160119/002efed4/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-QML-UI-DiveDetailsView-shift-dive-number-to-right-of.patch
Type: text/x-patch
Size: 1882 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160119/002efed4/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dive number after duration.png
Type: image/png
Size: 75011 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160119/002efed4/attachment-0002.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dive number shifted up.png
Type: image/png
Size: 77337 bytes
Desc: not available
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160119/002efed4/attachment-0003.png>


More information about the subsurface mailing list