[PATCH] QML UI DiveDetailsView: shift dive number to right of top row

Sebastian Kügler sebas at kde.org
Tue Jan 19 04:41:00 PST 2016


On Tuesday, January 19, 2016 20:43:25 Rick Walsh wrote:
> On my phone at least, the dive number gets cropped when viewing a dive.  It
> is especially bad for dives of one hour or more, where the duration text
> takes up a few extra characters.  By shifting the dive number up a row, so
> it follows the date, the display looks much better.  The attached patch
> does that, and as shown in the attached screenshots.
> 
> To make space for the dive number, the date grid item is reduced from 3
> columns (i.e. 3/4 of the screen width) to 2 columns (1/2 the screen
> width).  I can't see this being a problem, but I haven't tested any other
> locales or devices.

Look good to me.
-- 
sebas

Sebastian Kügler    |    http://vizZzion.org    |     http://kde.org



More information about the subsurface mailing list