[PATCH] QML UI: Don't explicitly set width of GridLayout items

Dirk Hohndel dirk at hohndel.org
Tue Jan 19 14:31:46 PST 2016


On Wed, Jan 20, 2016 at 08:54:42AM +1100, Rick Walsh wrote:
> On 20 Jan 2016 8:26 am, "Dirk Hohndel" <dirk at hohndel.org> wrote:
> >
> > On Tue, Jan 19, 2016 at 09:11:48PM +0000, Sebastian Kügler wrote:
> > > On Wednesday, January 20, 2016 06:44:08 Rick Walsh wrote:
> > > >                 height: saveButton.height
> > > > -               width: saveButton.width
> > > > +               Layout.preferredWidth: saveButton.width
> > >
> > > Shoud also change the height to Layout.preferredHeight, otherwise, it's
> good
> > > to go. (The change I suggested can be submitted separately).
> >
> > Yes please as I already committed this one
> >
> I'm at work now but if nobody wants to beat me to it, I'll send a patch
> tonight Australian time.

That would be great. We need more people to help out on the QML code, so
I'm more than happy to wait for you to send this.

/D


More information about the subsurface mailing list