[PATCH 1/3] QML-UI: Rearrange the DiveDetails page
j.bygdell at gmail.com
Mon Jan 25 11:50:07 PST 2016
> On 25 Jan 2016, at 20:40, Dirk Hohndel <dirk at hohndel.org> wrote:
> On Mon, Jan 25, 2016 at 08:38:37PM +0100, Joakim Bygdell wrote:
>>> On 25 Jan 2016, at 20:35, Jan Mulder <jlmulder at xs4all.nl> wrote:
>>> On 25-01-16 20:17, Dirk Hohndel wrote:
>>>> On Mon, Jan 25, 2016 at 06:44:50PM +0100, Joakim Bygdell wrote:
>>>>> After adding "Cylinder" to the DiveDetails page the objects had to be rearranged
>>>>> in order to better utilise the space.
>>>>> To get a cleaner look on smaller screens the left side is left aligned and the
>>>>> right side is right aligend.
>>>> I like the way this looks. And thanks for addressing the cylinder /
>>>> weights. That had been broken / missing for a while.
>>> This currently shows the first cilinder. Fine for recreational divers, but a dive I did with RB and 6 stages now looks like I did the dive with 1 AL40 :-)
>>> A solution could be to display "multiple" for dives with more than 1 cilinder.
>> That’s one way of doing it but if we want to enable simple editing on the mobile version it is better to only work on the
>> first cylinder. If you want to edit multiple cylinder with gas switches, use the full desktop version.
> Sure - but there needs to be some visual acknowledgement that there's more
> than one cylinder.
Should be simple enough to fix.
> On the weights this can simply be the sum of all weights. But then... what
> does editing that mean?
The weights IS the sum of everything.
Editing that just lets you put in the total weight you used for a particular dive.
For editing dives on the mobile handling anything other than the first cylinder might be tricky due to the limited screen size.
Maybe in the future if we build in a distinction between 5” phones and +8” tablets it is possible to do this in a UI friendly manner.
We shouldn't try to duplicate the full desktop version for the first release so some things will have to wait.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the subsurface