[PATCH 1/3] QML-UI: Rearrange the DiveDetails page

Joakim Bygdell j.bygdell at gmail.com
Tue Jan 26 03:26:31 PST 2016


On 26 January 2016 at 12:21, Rick Walsh <rickmwalsh at gmail.com> wrote:

>
>
> On 26 January 2016 at 21:54, Rick Walsh <rickmwalsh at gmail.com> wrote:
>
>> Jocke,
>>
>> On 26 January 2016 at 04:44, Joakim Bygdell <j.bygdell at gmail.com> wrote:
>>
>>> After adding "Cylinder" to the DiveDetails page the objects had to be
>>> rearranged
>>> in order to better utilise the space.
>>> To get a cleaner look on smaller screens the left side is left aligned
>>> and the
>>> right side is right aligend.
>>>
>>> Signed-off-by: Joakim Bygdell <j.bygdell at gmail.com>
>>> ---
>>>
>>
>> Forget about cylinders and weights (just kidding), it appears you have
>> fixed the annoying subsurface-mobile crashes I had been getting when
>> flicking through my dives.  Tack och grattis!
>>
>> Can others confirm this patch has fixed the issue?
>>
>
> On actually looking at what's displayed, this layout doesn't work for my
> device.  The whole page has been cropped down the right-hand side.  See the
> attached screenshot.
>
> The single cylinder displayed looks a bit odd too.  I had twin 12L back
> gas - the AL80 was my deco cylinder.  I like the suggestion of the
> non-editable 'multiple' option for existing dives with multiple cylinders
> added in the desktop program.  Similar logic would be appropriate for
> weights too
>

I sent in a patch for the multiple cylinder issue late last night, the
weights are the sum of all weights.

>
> But more importantly, I'm pleased the app doesn't crash for me.
>
> Rick
>
>
-- 
Jocke
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.subsurface-divelog.org/pipermail/subsurface/attachments/20160126/b3cc39d2/attachment.html>


More information about the subsurface mailing list