[PATCH 0/5] Improve and automate best mix calculations

Rick Walsh rickmwalsh at gmail.com
Fri Jul 1 00:26:05 PDT 2016


This patch series implements Robert's suggestion for best mix calculations.  It builds on what I did previously and is in master now.

He said it best in his email in May
http://lists.subsurface-divelog.org/pipermail/subsurface/2016-May/025699.html

Maybe that is the best option: Add two columns to the gas table, one with depth for which it is the best mix (O2-wise) and one with the depth that has an END of 30m (or the corresponding depth value). And the user can enter values there which change the percentages. And she can enter a special character (? or * for example) and that has the meaning of „max depth of the dive“ resp. gas change depth (if that is smaller than max depth).

What do you think? I would think we can afford the additional space for those columns.



I think I've implemented what he suggested, and it works in my testing.  But please test.  I've barely touched the Qt side of things previously, so I expect I've made mistakes (I just can't find them myself).

Rick

Rick Walsh (5):
  Add function to calculate gas maximum narcotic depth
  Add MOD and MND fields to cylindermodel
  Validate O2 in best mix
  Planner: automate calculation of best mix for max depth
  Planner: update cylinder mixes and MND and MOD when prefs are changed

 core/dive.c                     |  3 ++
 core/dive.h                     | 13 ++++++
 desktop-widgets/diveplanner.cpp |  3 ++
 qt-models/cylindermodel.cpp     | 88 ++++++++++++++++++++++++++++++++++++-----
 qt-models/cylindermodel.h       |  3 ++
 qt-models/diveplannermodel.cpp  | 19 ++++++++-
 qt-models/diveplannermodel.h    |  1 +
 7 files changed, 120 insertions(+), 10 deletions(-)

-- 
2.7.4



More information about the subsurface mailing list